-
Zash
I'm thinking https://docs.modernxmpp.org/client/groupchat/#bookmarks should have some words to the affect of "if `jabber:iq:private` is *not* advertised, but PEP is, go directly to XEP-0402"
-
MattJ
Definitely
-
Sam
I think in general that's correct, but I worry that converse.js is the only web client I've ever seen anyone use and it doesn't support 0402. If it were any other single client I'd ignore it, but that one seems kind of important.
-
Zash
What's your point?
-
Sam
I just mean as far as giving advise goes I worry that anything that doesn't include the only webclient is potentially bad advice
-
Zash
I don't understand
-
Holger
The proper fix is servers synchronizing between the three(?) storage methods. With servers that don't (like ejabberd), '402 clients will have their bookmarks synced only with Movim, I think.
-
Sam
Don't worry about it, I think I'm wrong now anyways.
-
Sam
This is advice for everyone, including converse.js. Doesn't matter if it's something an important thing doesn't do.
-
Sam
Also Siskin/Beagle both only do PEP native, so I suspect all iOS/MacOS users have different bookmarks
-
Sam
Holger: do you know if anyone is currently working on sync for ejabberd?
-
Zash
So you are saying that because Converse.js went ahead and did something that is now discouraged, we should ... do what?
-
Zash
I was talking about making the way forward more robust so that everyone doesn't fall back to private xml once we remove the conversion methods
-
Holger
Sam: I added some 0060 changes which I think are preconditions for '402 (e.g. support for `max_items=max`) over the past few months but not actual sync support yet no. (I mean '402 sync. We do sync PEP native with private XML.)
-
Sam
Zash: don't worry about it, you're right, I was wrong, it doesn't make sense to defer this because of converse.js.
-
Sam
Holger: *nods* thanks. I'll subscribe to the issue, I ran into this myself the other day (not just in the thing I'm working on or with the friend I've been trying to find a server for), so I'd definitely love to see it come to ejabberd (and conversations.im)
-
Holger
Another thing which I think is less trivial than it sounds is getting existing setups to bump default max_item limits for PEP. At least with ejabberd the limit has been 10 for many years, as real-world PEP use cases always been using 1 in practice.
-
Zash
XEP-0411 + recommendation to use private xml when there's no bookmarks2#compat advertised should ensure that things are working
-
Zash
Myeah, I wonder if even 256 is enough
-
Holger
So I'm a little worried that multi-item PEP solves a mostly academic issue at the cost of running into ugly breakage in practice.
-
Zash
I have a half-implemented idea about combining per-item size limits with item count limits
-
Holger
(But I do agree that multi-item PEP is the proper solution to these things in principle, obviously.)
-
Zash
With individual Bookmarks 2 items being quite small, allowing more of them seems sensible.
-
Holger
Yeah.
-
Zash
But you wouldn't want to allow over 9000 254.9K avatar data entries
-
Zash
So if one tries to keep per item size limit * max items below e.g. the stanza size limit or so, maybe?
-
Holger
Sounds good.
-
Zash
E.g. allowing 256 1kbyte items, or 1k 256-byte items
-
Zash
So then a RSM-less items request should get trough (modulo margins for wrapper overhead)
-
Zash
And of course xep-0060 already has a pubsub#max_payload_size field
-
Link Mauve
“18:57:49 Zash> I'm thinking https://docs.modernxmpp.org/client/groupchat/#bookmarks should have some words to the affect of "if `jabber:iq:private` is *not* advertised, but PEP is, go directly to XEP-0402"”, the last time I looked at this, jabber:iq:private was specified exactly nowhere, and some servers which do support this protocol didn’t advertise the feature.
-
Link Mauve
So today, we can’t assume the lack of the feature var to mean Private XML Storage isn’t available.
-
Link Mauve
We might need a negative feature, var="¬jabber:iq:private" or something.
-
Link Mauve
“19:44:14 Zash> I was talking about making the way forward more robust so that everyone doesn't fall back to private xml once we remove the conversion methods”, if we ever manage to rid the world of any Private XML client, we can change the meaning of the #compat feature to “servers must advertise it, but it is otherwise meaningless”.
-
Link Mauve
Until we’re there…
-
Link Mauve
“19:47:28 Zash> Myeah, I wonder if even 256 is enough”, I’m at 189 items atm, with a limit increased to 1024.
-
Link Mauve
I might have been an avid MUC traveler, but 256 would feel way too cramped for me, especially given the extremely bad failure case once this limit is reached.
-
Link Mauve
Zash, compression would also be really useful for this usecase. :-°
-
Zash
Remember that it is the uncompressed size of stanzas that limits apply to
-
pep.
failure case is something I wanted to tackle as well..
-
pep.
Telling implementations "Hey it's the end of the thing" instead of not saying anything
-
Zash
What happens when you publish the max_item+1'th item in PubSub?
-
pep.
That's my question!! https://mail.jabber.org/pipermail/standards/2019-October/036503.html